CGI/Perl Guide | Learning Center | Forums | Advertise | Login
Site Search: in

  Main Index MAIN
INDEX
Search Posts SEARCH
POSTS
Who's Online WHO'S
ONLINE
Log in LOG
IN

Home: Perl Programming Help: Intermediate: Re: [Sam Kennedy] Thread or Fork?: Edit Log



FishMonger
Veteran / Moderator

Aug 31, 2012, 7:57 AM


Views: 5359
Re: [Sam Kennedy] Thread or Fork?

While you work on overhauling the code, you may want to take these things into consideration.

1) You're calling your main() sub prior to declaring/initializing the file scoped vars that the sub uses and you have way too many of those vars.

2) The use of a main() sub is unneeded and only servers to add unnecessary indentation.

3) Every sub is accessing file scoped vars directly, which is a bad coding practice. You should a) declare your vars in the smallest scope that they require and b) pass globally scoped vars to subs rather than accessing them directly.

4) You have way too much duplication of code. Instead of having individual subs that update a specific var, you should make the subs more generic and pass in vars by reference. That alone would mean you could drop most of those subs.

5) The C style for loop is very verbose and looks cluttered. It's much cleaner and easier to use Perl's style of the for loop.

6) I suspect that the multiple use of nested for loops could be the source of part of the slowdown. I have not analyzed them enough, but I'm pretty sure that those blocks can be reworked to reduce the amount of looping.

7) Your save_genes() sub looks pretty inefficient. The use of the join function could help in cleaning up or getting rid of those for loops. It might be better and more efficient to build up a data structure and then dump that to the file in one print statement.

With more analysis, I could probably come up with more things to consider, but that should be enough to get started.


(This post was edited by FishMonger on Aug 31, 2012, 7:58 AM)


Edit Log:
Post edited by FishMonger (Veteran) on Aug 31, 2012, 7:58 AM


Search for (options) Powered by Gossamer Forum v.1.2.0

Web Applications & Managed Hosting Powered by Gossamer Threads
Visit our Mailing List Archives