perlkid
stranger
Oct 12, 2000, 10:09 AM
Post #7 of 8
(2564 views)
|
|
Re: Almost there, just an error I don't know what it is about
[In reply to]
|
Can't Post
|
|
I had a lot of trouble with an uploading script that I was making today and yesturday, I always knew I would have to learn how to actually make an upload utility myself someday so I didn't have to rely on scripts I don't fully understand. Then when I was givin this script I learned that it's not all that difficult.
<BLOCKQUOTE><font size="1" face="Arial,Helvetica,sans serif">code:</font><HR>
#!/usr/local/bin/perl
#file: upload.pl
######################################################################
#Copyright 1998 David Turley (dturley@pobox.com>
#Last Modified April 30, 1998
#This script may not be resold or distributed without the author's
#express written permission.
#The current version of the script is available at
#http://www.pobox.com/~dturley/script.html
######################################################################
##################### DESCRIPTION ##############################
#This script allows users to upload files to a predetermined
#directory on your server. After a successful upload, email is
#sent to the adminstrator informing of an uploaded file.
#
#You must have the CGI.pm module installed. This module is distributed
#with recent Perl distributions. Info on the module can be found at:
# http://www.genome.wi.mit.edu/ftp/pub/software/WWW/cgi_docs.html
######################## SETUP #################################
# Enter the correct values for these variables below:
#
# $mailTo -- This is the email address to which email notification of
# an upload will be sent.
#
# $upload_dir -- The directory where uploaded files will be saved.
#
# You may use either sendmail or the Net::SMTP module to send email:
# To use sendmail, set $use_sendmail = "yes",
# To use Net::SMTP module, set $use_sendmail = "no".
# $mail_path -- The path to your sendmail program.
# OR
# $mail_server -- Use this variable if you aren't using sendmail.
# Note: you can comment out the unused mail variable.
#
# %PASSWORDS -- Set names and paswords for valid users here. Be sure
# to follow proper syntax.
#
#
#Upload the script and set proper permissions for your server. There
#is no separate HTML form to upload. All forms are generated by this
#script. To access the upload form, enter the URL for the script in
#your web browser.
######################## BEGIN SETUP #################################
use CGI qw/:standard :html3/;
use Net::SMTP; ##comment out if not using
$mailTo = 'you@youremail.com';
$upload_dir = '/www/your/directory/';
$use_sendmail = 1; #set to 1 to use sendmail, 0 to use Net::SMTP module
$mail_path = '/usr/sbin/sendmail'; #for send_email1()
## OR ## ##you may comment out unused variable
$mail_server = 'pop.binary.net'; #for send_email2()
%PASSWORDS =
('some name' => 'pass',
'guest' => 'guest',
);
######################## END SETUP ##################################
print header,
start_html(-title=>'Upload File',-bgcolor=>'white'),
h1({-align=>CENTER},'File Upload Form');
if (param) {
check_password();
upload_file();
if ($use_sendmail) { send_email1(); }
else {send_email2();}
}
else {
print_form();
}
print hr;
print 'Upload script by ',
a({-href=>'http://www.pobox.com/~dturley/'},'David Turley');
print end_html;
exit(0);
################SUBROUTINES#################################
sub print_form {
print start_multipart_form(),
table(
TR({-align=>LEFT},
th('Enter Your Name: '),
td(textfield(-name=>'user',-size=>30))
),
TR({-align=>LEFT},
th('Enter Your Password: '),
td(textfield(-name=>'password',-size=>30))
),
TR({-align=>LEFT},
th('Enter a File to Upload: '),
td(filefield(-name=>'upload',-size=>50))
),
TR({-align=>LEFT},
th({-valign=>TOP},'Enter a Brief Description of the File: '),
td(textarea(-name=>'comment',-rows=>10,-cols=>50,-wrap=>physical))
),
TR({-align=>LEFT},
td({-colspan=>2,-align=>center},submit(-label=>'Upload File'))
)
),
end_form;
}
sub upload_file {
my $length;
my $size;
my $file = param('upload');
$file =~ m!([^/:\\]*)$!; #capture file name
my $short_name = $1;
if (!$file) {
print p({-align=>center},'You did not enter a file to upload.');
print p({-align=>center},a({-href=>url},'Go back and try again.'));
print end_html;
exit(0);
}
if (-e "$upload_dir/$short_name") {
print p({-align=>center},'The file name ',b($short_name), 'has already been used.',
'Please change the name of your local file and try again.');
print p({-align=>center},a({-href=>url},'Try Again.'));
print end_html;
exit(0);
}
open (SAVE,">$upload_dir/$short_name") | | die $!;
while ($size = read($file,$data,1024)) {
print SAVE $data;
$total_size += $size;
}
close SAVE;
if ($total_size > 0) { #file was transferred
print p('Your file has been uploaded. Here is the relevant information:');
print p(b('File Name: '),$file,br,b('File Size: '),$total_size);
print p(a({-href=>url},'Upload Another File'));
}
else { #nothing was uploaded
print p({-align=>center},'No file was transferred. ',
'Please be sure you entered a valid file name.');
print p({-align=>center},a({-href=>url},'Try Again.'));
print end_html;
unlink "$upload_dir/$short_name"; #get rid of file created by open
exit(0);
}
}
sub send_email1 {
my $user = param('user');
my $file = param('upload');
$file =~ m!([^/:\\]*)$!; #capture file name
my $short_name = $1;
my $comments = param('comment');
open (SENDMAIL, "| $mail_path -t") | | die $!;
print SENDMAIL "Subject: File Upload\n";
print SENDMAIL "From: $mailTo\n";
print SENDMAIL "To: $mailTo\n\n";
print SENDMAIL "A file has been uploaded to $upload_dir.\n";
print SENDMAIL "New Filename: $short_name\n";
print SENDMAIL "Size: $total_size\n";
print SENDMAIL "Uploaded by: $user\n";
print SENDMAIL "Comments:\n";
print SENDMAIL "$comments\n";
close (SENDMAIL);
}
sub send_email2 {
my $user = param('user');
my $file = param('upload');
$file =~ m!([^/:\\]*)$!; #capture file name
my $short_name = $1;
my $comments = param('comment');
$smtp = Net::SMTP->new($mail_server);
$smtp->mail($ENV{USER});
$smtp->to($mailTo);
$smtp->data();
$smtp->datasend("Subject: File Upload\n");
$smtp->datasend("From: $mailTo\n");
$smtp->datasend("To: $mailTo\n");
$smtp->datasend("\n");
$smtp->datasend("A file has been uploaded to $upload_dir.\n");
$smtp->datasend("New Filename: $short_name\n");
$smtp->datasend("Size: $total_size\n");
$smtp->datasend("Uploaded by: $user\n");
$smtp->datasend("Comments:\n");
$smtp->datasend("$comments\n");
$smtp->dataend();
$smtp->quit;
}
sub check_password {
my $user = param('user');
my $pass = param('password');
my $okay = 0;
foreach $key (keys %PASSWORDS) {
if (($key eq $user) && ($PASSWORDS{$key} eq $pass)) {
$okay = 1;
last;
}
}
if ($okay != 1) {
print p({-align=>center},'You must enter a valid name and password to use this script.');
print p({-align=>center},a({-href=>url},'Go back and try again.'));
print end_html;
exit(0);
}
}
</pre><HR></BLOCKQUOTE>
Just upload that whole file and the guy had a few extra things than I needed.
I looked at the upload sub routin and I now know what the trick is.
The biggist problem I had was the actuall form. I couldn't get any data at all from the users computer. Finally I went over everything and I found that I left out the form tag
ENCTYPE="multipart/form-data"
Then the browser must have understood to send the data, then everything worked. Usually I found the upload scripts to be really touchy.
But now I know that I can use them almost anywhere. 
Just sharing my mistakes and solutions.
I didn't really read any posts all the way through because I'm in a hurry, but I just had to share that with you.
perlkid
|
MAIN
SEARCH
WHO'S 
LOG 
or to go over the errors I get? Much thanks!