Jul 13, 2013, 2:42 PM
Post #6 of 7
I completely agree with Fishmongere that these scripts are very poorly written. I can't believe an IT professional would write such garbage.
Re: [FishMonger] Scripting Help Needed...
[In reply to]
I think the worst case (at least I had never seen something like that before) is this undo_script.pl script:
system("rm -r /home/student1 /home/student2 /home/instructor1 /home/instructor2");
system("rm -r /var/www/student1");
system("rm -r /var/www/student2");
system("rm -r /var/www/instructor1");
system("rm -r /var/www/instructor2");
This is just pathetically silly.
It is supposed to be a Perl script and there isn't even one single Perl command, just a list of system commands with shell commands. Why is it not done in a shell script?
I agree with Fishmonger, these scripts should most probably be completely rewritten from scratch.
One last additional point: it seems, from what you are saying, that you have been asked to rewrite/improve/refactor these scripts whereas you are not a developper (or at least not a Perl developper). I am a bit surprised (which is not to say that I challenge in any respect what you are saying). A university usually has a huge mass of talented individuals with knowledge in dozens of different technologies. And Perl might not be the dominant language today, but it is still probably among the top 5 or at least top 10 languages of today. I am puzzled that your university does not have the necessary competencies. Can you please give me the name of that university, I want to make sure that my children will not go to such a rotten place (this is not just rhetorical discussion, my son will actually be completing next year his IT master cursus, I really want him to go in a real place).