CGI/Perl Guide | Learning Center | Forums | Advertise | Login
Site Search: in

  Main Index MAIN
INDEX
Search Posts SEARCH
POSTS
Who's Online WHO'S
ONLINE
Log in LOG
IN

Home: General Discussions: Feedback:
'Should I...' and 'How to...' submit a script

 



S_Shrum
User

Feb 26, 2001, 4:30 PM

Post #1 of 4 (4365 views)
'Should I...' and 'How to...' submit a script Can't Post

I looked around and found nothing like this so I made one...maybe I did so redudently???

During my scripting of a flatfile --> HTML table script, I found that I wanted the forms that were submitting the the data to be dynamic; based upon the data in various other databases on my site. I decided that I could make a form element script that would create comboboxes, radio buttons and checkbox with a user defined file, field, and element name. You can see what I mean by visiting the following link:

http://www.shrum.net/soaring/forms/slope.shtml
http://www.shrum.net/soaring/forms/channel.shtml

The data in the combo/check boxes is coming from a database (pipe-delimited, text) that I created.

The thing works beautifully (I think...<pat on the back>). Does anyone know if a script already exists that does the same thing or if I should just submit it (and if so where)?

I am a bit hesitent as I am a newbie to scripting and I may have done things that the gurus on high would kringe at...hmmm...that being said, is there anyone/anywhere that I can get a script evaluated/optimized???

Sean Shrum
sean@shrum.net
www.shrum.net


Jasmine
Administrator

Feb 27, 2001, 10:17 AM

Post #2 of 4 (4361 views)
Re: 'Should I...' and 'How to...' submit a script [In reply to] Can't Post

Oh no! I didn't realize that the script was live and submissions immediately available on the site! Please delete my test entry, which unfortunately shows that the program has 2 major flaws:

1) You're not checking for | in user input -- this is skewing the fields

2) You're immediately accepting entries into your publicly viewable site. This is an invitation for abuse.

It's an excellent idea to have your code reviewed. I know someone who does this for a fee (when time permits) at around $200/hr, and the total hours depends on the length of your code and what you want the program reviewed for. So he doesn't get inundated with emails, I'm not going to put his name here, but let's say that he's a well-known person in the Perl community.

If you're interested, I can put you in contact with him -- contact me privately at djasmine@perlarchive.com. Or, if you don't feel like you're ready for a professional review yet, you can attach your code to a reply and solicit comments from the general public.



S_Shrum
User

Feb 27, 2001, 12:44 PM

Post #3 of 4 (4359 views)
Re: 'Should I...' and 'How to...' submit a script [In reply to] Can't Post

No problem...I backed up the data last night so fixing it isn't that hard.

My site is down (1dollarhosting has been the target of hacker attacks the last month ergo they go down, I go down). I will make the corrections when it is back up.

Good point about testing for the field delimiter in the data. I will write something that will convert those

As for the live submissions and abuse...I didn't really anticipate that would occur much. I figured that I would trust the community at large to be kind. I also figured that if someone really wanted to abuse the system, they would hit someone bigger (ie: IRS, whitehouse.gov, Microsoft, etc.). The time it would take to "secure" data outwayed the ease of simply repairing the effected database. Ultimately, my log file records everything and I could always start doing domain blocking (worst case; don't want to but could). Good point, nonetheless.

Afterwards, where should I post the script for review? There isn't really a "Check out my script and give advice" forum.

Sean Shrum
sean@shrum.net
www.shrum.net


Jasmine
Administrator

Feb 27, 2001, 8:29 PM

Post #4 of 4 (4356 views)
Re: 'Should I...' and 'How to...' submit a script [In reply to] Can't Post

If you want some comments about your code, you can just post it in one of the programming forums (Beginner, Intermediate, or Advanced). Better yet, attach the code to your request for comments to your post.


 
 


Search for (options) Powered by Gossamer Forum v.1.2.0

Web Applications & Managed Hosting Powered by Gossamer Threads
Visit our Mailing List Archives